Allow empty string as cvc config #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current error message was unclear (no valid cvc) Missing parameters will be caught individually. Useful for alchLambda cvc, which needs no config.
jhenin
force-pushed
the
empty_cvc_config
branch
from
6b75c48
to
7daf68d
Compare
giacomofiorin
approved these changes
Feb 11, 2024
There was a problem hiding this comment.
Good change and (more importantly) very easy to review :-)
Even if there were are any side effects not caught by current tests, #643 will change things much further anyway.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current error message was unclear (no valid cvc)
Missing parameters will be caught individually.
Useful for alchLambda cvc, which needs no config.
Fixes #394