Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: simplify implement_doit_method decorator #178

Merged
merged 3 commits into from
Nov 4, 2021
Merged

fix: simplify implement_doit_method decorator #178

merged 3 commits into from
Nov 4, 2021

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Nov 4, 2021 •
edited
Loading

The @implement_doit_method decorator was using one inline function layer too many. So now you have to write

@implement_doit_method
class MyExpr(UnevaluatedExpression):
    ...

instead of

@implement_doit_method()
class MyExpr(UnevaluatedExpression):
    ...

@redeboer redeboer added the ⚠️ Interface Breaking changes to the API label Nov 4, 2021
@redeboer redeboer added this to the 0.12.0 milestone Nov 4, 2021
@redeboer redeboer self-assigned this Nov 4, 2021
@redeboer redeboer merged commit b8dd347 into main Nov 4, 2021
@redeboer redeboer deleted the implement_doit_decorator branch November 4, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@redeboer redeboer

Labels
⚠️ Interface Breaking changes to the API
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
1 participant
@redeboer