This repository has been archived by the owner on Oct 11, 2021. It is now read-only.
fix: avoid validating when building dict #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more convenient when debugging
The framework should just dump in the correct format, validation is about input
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
==========================================
+ Coverage 90.02% 90.07% +0.04%
==========================================
Files 22 22
Lines 3440 3437 -3
Branches 847 847
==========================================
- Hits 3097 3096 -1
+ Misses 173 172 -1
+ Partials 170 169 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests should make sure that the framework dumps in the correct format. JSON validation is only relevant for input (e.g. a hand-written amplitude model or particle list).