This repository has been archived by the owner on Oct 11, 2021. It is now read-only.
refactor: rename pole to real and imag #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #439 +/- ##
==========================================
+ Coverage 90.05% 90.11% +0.05%
==========================================
Files 22 22
Lines 3359 3359
Branches 836 836
==========================================
+ Hits 3025 3027 +2
+ Misses 170 169 -1
+ Partials 164 163 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
spflueger
approved these changes
Jan 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #436 (comment)
Alternative would be to rethink the concept of a
FitParameter: that the value can befloatorcomplex, or that you can have different types ofFitParameter. See also #397 (comment).