Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: implement amplitude visualization in manual notebook #87

Merged
merged 15 commits into from
Aug 21, 2024
Merged

FEAT: implement amplitude visualization in manual notebook #87

merged 15 commits into from
Aug 21, 2024

Conversation

shenvitor
Copy link
Member

@shenvitor shenvitor commented Aug 19, 2024 •
edited
Loading

p.s. first I will do this in EtaPiP manual notebook, later I will transfer this similarly to LambdaLPi in a different PR.

@shenvitor shenvitor self-assigned this Aug 19, 2024
@shenvitor shenvitor added ✨ Feature New feature added to the package 📝 Docs Improvements or additions to documentation labels Aug 19, 2024
@redeboer redeboer changed the title FEAT: Sympy and transformer FEAT: implement amplitude visualization in manual notebook Aug 19, 2024
@shenvitor shenvitor marked this pull request as draft August 19, 2024 15:30
redeboer
redeboer requested changes Aug 19, 2024
View reviewed changes
docs/eta-pi-p/index.md Outdated Show resolved Hide resolved
docs/eta-pi-p/index.md Outdated Show resolved Hide resolved
docs/eta-pi-p/index.md Show resolved Hide resolved
redeboer
redeboer requested changes Aug 20, 2024
View reviewed changes
docs/eta-pi-p/manual.ipynb Outdated Show resolved Hide resolved
docs/eta-pi-p/manual.ipynb Outdated Show resolved Hide resolved
docs/eta-pi-p/manual.ipynb Outdated Show resolved Hide resolved
docs/eta-pi-p/manual.ipynb Outdated Show resolved Hide resolved
docs/eta-pi-p/manual.ipynb Outdated Show resolved Hide resolved
redeboer
redeboer requested changes Aug 20, 2024
View reviewed changes
docs/eta-pi-p/manual.ipynb Outdated Show resolved Hide resolved
docs/eta-pi-p/manual.ipynb Outdated Show resolved Hide resolved
docs/eta-pi-p/manual.ipynb Outdated Show resolved Hide resolved
docs/eta-pi-p/manual.ipynb Outdated Show resolved Hide resolved
docs/eta-pi-p/manual.ipynb Outdated Show resolved Hide resolved
@shenvitor shenvitor mentioned this pull request Aug 21, 2024
Closed
@shenvitor shenvitor marked this pull request as ready for review August 21, 2024 13:28
redeboer
redeboer approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 🤙

@shenvitor shenvitor merged commit 0a2d766 into main Aug 21, 2024
6 checks passed
@shenvitor shenvitor deleted the transformer-sympy branch August 21, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redeboer redeboer redeboer approved these changes

Assignees

@shenvitor shenvitor

Labels
📝 Docs Improvements or additions to documentation ✨ Feature New feature added to the package
Projects
None yet
Milestone
No milestone
2 participants
@shenvitor @redeboer