Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: run Prettier on GitHub Actions if v4 alpha #232

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Dec 1, 2023

Prettier v4 cannot be run with https://github.com/pre-commit/mirrors-prettier because of the new Prettier interface. This PR makes the hook run on GitHub Actions, so that we can set PRETTIER_LEGACY_CLI=1.

@redeboer redeboer added the 🐛 Bug Something isn't working label Dec 1, 2023
@redeboer redeboer self-assigned this Dec 1, 2023
@redeboer redeboer changed the title FIX: run prettier on GitHub Actions if v4 alpha FIX: run Prettier on GitHub Actions if v4 alpha Dec 1, 2023
@redeboer redeboer marked this pull request as ready for review December 1, 2023 12:59
@redeboer redeboer enabled auto-merge (squash) December 1, 2023 12:59
@redeboer redeboer merged commit b8b5ef5 into main Dec 1, 2023
23 checks passed
@redeboer redeboer deleted the prettier-precommit-hotfix branch December 1, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant