-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve documentation with plots #142
Conversation
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
=======================================
Coverage 72.43% 72.43%
=======================================
Files 8 8
Lines 584 584
Branches 83 83
=======================================
Hits 423 423
Misses 131 131
Partials 30 30
Flags with carried forward coverage won't be shown. Click here to find out more. |
@Leongrim @sebastianJaeger These changes additions are to help you guys, could you have a look? @spflueger You can have a look as well, but I did not modify the source code. |
So for the record: best to review the rendered pages You can also download the notebooks from there (upper right) and run them yourself to see if you would like to add some more code snippets that are interesting to the physicist. (Better would of course be to checkout the branch of this PR.) |
In Step 2 it is mentioned that not all the invariant masses are registered. Are all the angles registered? |
Good point. Actually it's just a quick remark that had to be there while #122 is still out there. Unfortunately, the PR preview does not render output, but from the >>> data_set = kin.convert(data_sample)
>>> list(data_set.keys())
['mSq_2_3_4',
'mSq_3_4',
'mSq_2',
'mSq_3',
'mSq_4',
'theta+3_4+2',
'phi+3_4+2',
'theta+3+4_vs_2',
'phi+3+4_vs_2'] Meaning also only the angles of the relevant subsystems are not generated. The best solution would be to create some |
Summary of changes:
matplotlib