Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove default dynamics #180

Merged
merged 10 commits into from
Nov 27, 2020
Merged

fix: remove default dynamics #180

merged 10 commits into from
Nov 27, 2020

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Nov 26, 2020

Implements ComPWA/expertsystem#395 (release 0.6.4) and removes the default dynamics.

if decaying_state.name not in self._dynamics:
self._dynamics.set_breit_wigner(decaying_state.name)

That was an implementation that seemed convenient, but modified the dynamics section of the input AmplitudeModel.

Note that a long-term fix should come through #172 and ComPWA/expertsystem#22

@redeboer redeboer added the 🐛 Bug Something isn't working label Nov 26, 2020
@redeboer redeboer self-assigned this Nov 26, 2020
@redeboer
Copy link
Member Author

Note: 10e115e has to be reverted once ComPWA/expertsystem#395 is through and expertsystem==0.6.4 is released

@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #180 (9d4e16f) into master (6c23889) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
- Coverage   76.25%   76.17%   -0.08%     
==========================================
  Files          12       12              
  Lines         598      596       -2     
  Branches       85       84       -1     
==========================================
- Hits          456      454       -2     
  Misses        107      107              
  Partials       35       35              
Flag Coverage Δ
unittests 76.17% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ensorwaves/physics/helicity_formalism/amplitude.py 72.83% <ø> (-0.21%) ⬇️

@redeboer redeboer merged commit b1883cc into ComPWA:master Nov 27, 2020
@redeboer redeboer deleted the no-default-dynamics branch November 27, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants