-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove default dynamics #180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: 10e115e has to be reverted once ComPWA/expertsystem#395 is through and |
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
- Coverage 76.25% 76.17% -0.08%
==========================================
Files 12 12
Lines 598 596 -2
Branches 85 84 -1
==========================================
- Hits 456 454 -2
Misses 107 107
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more.
|
spflueger
reviewed
Nov 27, 2020
spflueger
reviewed
Nov 27, 2020
spflueger
approved these changes
Nov 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements ComPWA/expertsystem#395 (release 0.6.4) and removes the default dynamics.
tensorwaves/src/tensorwaves/physics/helicity_formalism/amplitude.py
Lines 159 to 160 in ca494ea
That was an implementation that seemed convenient, but modified the dynamics section of the input
AmplitudeModel
.Note that a long-term fix should come through #172 and ComPWA/expertsystem#22