Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add mass*width factor to relBW w/o ff #189

Merged
merged 2 commits into from
Jan 6, 2021
Merged

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Jan 6, 2021

Adds a factor of mass * width to the relativistic Breit-Wigner without form factor as well. Previously, this only happened for the rel. BW with form factor.

Note: this more or less restores the distribution of the example workflow to the first distribution shown in #187 (comment).

To summarize (the red line initial fit model can be ignored):

  1. 574fe16 (v0.1.3, before with FF fix of fix!: use es.FormFactor in _RelativisticBreitWigner #187)
    image

  2. c35f270 (after fix!: use es.FormFactor in _RelativisticBreitWigner #187)
    image

  3. 1f7d1be (this PR)
    image

@redeboer redeboer added the 🐛 Bug Something isn't working label Jan 6, 2021
@redeboer redeboer self-assigned this Jan 6, 2021
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #189 (1f7d1be) into master (e0b02d4) will decrease coverage by 0.23%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
- Coverage   82.41%   82.17%   -0.24%     
==========================================
  Files          13       13              
  Lines         705      707       +2     
  Branches       98       98              
==========================================
  Hits          581      581              
- Misses         89       91       +2     
  Partials       35       35              
Flag Coverage Δ
unittests 82.17% <0.00%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ensorwaves/physics/helicity_formalism/amplitude.py 75.27% <0.00%> (-0.56%) ⬇️

Copy link
Member

@spflueger spflueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@redeboer redeboer merged commit 7c95713 into master Jan 6, 2021
@redeboer redeboer deleted the fix-rel-BW-without-ff branch January 6, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants