-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: illustrate example without expertsystem #232
Conversation
@spflueger Have a look at the phrasing to see if you agree. I think this notebook also helps to rethink the design and naming (particularly in the |
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
=======================================
Coverage 81.65% 81.65%
=======================================
Files 12 12
Lines 507 507
Branches 64 64
=======================================
Hits 414 414
Misses 71 71
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more. |
c5039ac
to
06077be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done. I have a few comments on some wordings and things that should be pointed out. Approved it already though
Thanks for the comments @spflueger, I addressed them in ca36e86 |
Added a new page
usage/basics
that shows how to generate data for 1D and 2D expressions without using theexpertsystem
. This illustrates what happens behind the scenes intensorwaves
.