Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: refer to compwa-org for contributing #309

Merged
merged 4 commits into from
Aug 30, 2021

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Aug 30, 2021

@redeboer redeboer added the 🖱️ DX Improvements to the Developer Experience label Aug 30, 2021
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #309 (9307e9d) into main (983e1b7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #309   +/-   ##
=======================================
  Coverage   80.58%   80.58%           
=======================================
  Files          12       12           
  Lines         814      814           
=======================================
  Hits          656      656           
  Misses        158      158           
Flag Coverage Δ
unittests 80.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@redeboer redeboer self-assigned this Aug 30, 2021
@redeboer redeboer added this to the 0.3.1 milestone Aug 30, 2021
@redeboer redeboer changed the title ci: upgrade pinned requirements docs: refer to compwa-org for contributing Aug 30, 2021
@redeboer
Copy link
Member Author

redeboer commented Aug 30, 2021

909df9b is ok as long as black is used as a local pre-commit hook

- id: black
name: black
entry: black
language: system
types:
- python

Once we switch to pre-commit.ci though (e.g. ComPWA/qrules#87) with a repo hook for black, black versions will start to mismatch after pre-commit autoupdate.

@redeboer redeboer enabled auto-merge (squash) August 30, 2021 08:32
@redeboer redeboer merged commit c1ab1f3 into main Aug 30, 2021
@redeboer redeboer deleted the create-pull-request/patch-1630289752 branch August 30, 2021 08:36
@redeboer redeboer added 📝 Docs Improvements or additions to documentation and removed 🖱️ DX Improvements to the Developer Experience labels Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 Docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants