Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct version boundary syntax for pip #311

Merged
merged 3 commits into from
Aug 30, 2021
Merged

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Aug 30, 2021

Fix-up to #310

ampform >= 0.10.*, <= 0.11.*

resulted in version conflicts downstream. AmpForm is now also correctly updated: 626abe1.

@redeboer redeboer added this to the 0.3.1 milestone Aug 30, 2021
@redeboer redeboer self-assigned this Aug 30, 2021
@redeboer redeboer added the 🐛 Bug Something isn't working label Aug 30, 2021
@redeboer redeboer marked this pull request as draft August 30, 2021 13:34
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #311 (2cef8de) into main (57f6ec0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #311   +/-   ##
=======================================
  Coverage   80.58%   80.58%           
=======================================
  Files          12       12           
  Lines         814      814           
=======================================
  Hits          656      656           
  Misses        158      158           
Flag Coverage Δ
unittests 80.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Currently shows issues that cannot be fixed quickly, so removed
temporarily.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@redeboer redeboer marked this pull request as ready for review August 30, 2021 15:37
@redeboer
Copy link
Member Author

Analytic continuation notebook had to be removed (2cef8de). This will be reverted and fixed in #312.

@redeboer redeboer enabled auto-merge (squash) August 30, 2021 15:40
@redeboer redeboer merged commit d1465c1 into main Aug 30, 2021
@redeboer redeboer deleted the fix-ampform-pinning branch August 30, 2021 15:42
@redeboer redeboer modified the milestones: 0.3.1, 0.3.2 Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant