Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: split unit tests from integration tests #349

Merged
merged 10 commits into from
Nov 25, 2021

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Nov 25, 2021

All tests that require AmpForm have been seperated from proper unit tests (that require no additional dependencies). The folder structure under tests is now:

tests
├── integration
└── unit

Additional improvements:

  • Fixtures for the AmpForm tests have been parametrized:
    • qrules.ReactionInfo is parametrized with the canonica-helicity and helicity formalism.
    • SympyModel is constructed with and without max_complexity argument in the constructor, so that optimized_lambdify is tested as well.
  • Improved error message of LambdifiedFunction.update_parameters: over-defined parameters were computed incorrectly. In addition, the error message now prints the expected parameters.
  • Callbacks can now take pathlib.Path (previously only str). This makes it possible to convert the output_dir fixture into a Path as well.

@redeboer redeboer added the 🔨 Maintenance Maintenance and upkeep improvements label Nov 25, 2021
@redeboer redeboer self-assigned this Nov 25, 2021
@redeboer redeboer added this to the 0.4.0 milestone Nov 25, 2021
@redeboer redeboer enabled auto-merge (squash) November 25, 2021 14:00
@redeboer redeboer merged commit b5abfad into ComPWA:main Nov 25, 2021
@redeboer redeboer deleted the split-integration-unit-tests branch November 25, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Maintenance Maintenance and upkeep improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant