ci: avoid callbacks if unspecified #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redeboer
force-pushed
the
improve-callbacks
branch
from
919ed0c
to
df0c9b0
Compare
Merged
auto-merge was automatically disabled
December 2, 2021 17:25
Pull request was converted to draft
redeboer
force-pushed
the
improve-callbacks
branch
from
ca0dbf5
to
0318e66
Compare
redeboer
force-pushed
the
improve-callbacks
branch
from
0318e66
to
7a99e36
Compare
This reverts commit b0641fb.
Previously, if no callback was specified in the optimizer constructor, an empty CallbackList would be created and on_optimize_end etc were always called. This is (theoretically slower).
redeboer
added a commit
that referenced
this pull request
Dec 7, 2021
* chore: use new attr API for FitResult * ci: fail pytest on warnings * fix: add attrs as dependency * fix: close stream in Loadable callbacks * fix: implement __eq__ for CallbackList * refactor: avoid callbacks if unspecified * test: put Minuit2 tests under TestMinuit2 class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if no callback was specified in the optimizer constructor, an empty CallbackList would be created and on_optimize_end etc were always called. This is (theoretically) slower.
Some other improvements:
attrsnext-generation API (see also Use nbmake in all repos compwa.github.io#90).