-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: generalize data generation interface #392
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redeboer
added
📝 Docs
Improvements or additions to documentation
⚠️ Interface
Breaking changes to the API
labels
Jan 3, 2022
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
redeboer
force-pushed
the
generalize-data-interface
branch
from
January 3, 2022 14:37
9a63a21
to
4a469ee
Compare
Hit-and-miss samples are now generated with an unweighted phsp sample, so this results in different numbers (but a same distribution)
…ator Fixes the issue that was addressed in 7c75c90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large refactoring of the
data
module with the aim to generalize its hit-and-miss mechanisms to general domainDataSample
types.Interface changes
generate_data()
andgenerate_phsp()
façade functions. The new way to generate phase space and hit-and-miss data samples is:UniformRealNumberGenerator
->RealNumberGenerator
PhaseSpaceGenerator
->DataGenerator
PhaseSpaceGenerator.setup()
has been merged into the constructor (DataGenerator.__init__()
) and removed from the interface.TFPhaseSpaceGenerator
into an unweightedTFPhaseSpaceGenerator
(implementsDataGenerator
) and aTFWeightedPhaseSpaceGenerator
(implementsWeightedDataGenerator
).TFPhaseSpaceGenerator
can be used instead of the oldgenerate_phsp()
function.data.rng
New features
DataGenerator
, which does not generate weights as opposed toFourMomentumGenerator
.IntensityDistributionGenerator
, which should be used instead ofgenerate_data()
IdentityTransformer
, which is just the identity implementation of aDataTransformer
.NumpyUniformRNG