Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: activate and address pyright strict type checking #467

Merged
merged 4 commits into from
Oct 31, 2022
Merged

MAINT: activate and address pyright strict type checking #467

merged 4 commits into from
Oct 31, 2022

Conversation

redeboer
Copy link
Member

Set python.analysis.typeCheckingMode to "strict" and addressed issues. Perhaps this can eventually substitute mypy, which is horribly slow with tensorflow+sympy.

@redeboer redeboer added 🔨 Maintenance Maintenance and upkeep improvements 🖱️ DX Improvements to the Developer Experience labels Oct 31, 2022
@redeboer redeboer added this to the 0.4.9 milestone Oct 31, 2022
@redeboer redeboer self-assigned this Oct 31, 2022
@redeboer redeboer enabled auto-merge (squash) October 31, 2022 11:38
@redeboer redeboer changed the title Pyright strict checking MAINT: activate and address pyright strict type checking Oct 31, 2022
@redeboer redeboer enabled auto-merge (squash) October 31, 2022 11:40
@redeboer redeboer merged commit 64215bf into ComPWA:main Oct 31, 2022
@redeboer redeboer deleted the pyright-strict-checking branch October 31, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@redeboer redeboer

Labels
🖱️ DX Improvements to the Developer Experience 🔨 Maintenance Maintenance and upkeep improvements
Projects
None yet
Milestone
0.4.9
Development

Successfully merging this pull request may close these issues.
1 participant
@redeboer