Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a publisher for UIControl events #27

Merged
merged 1 commit into from
Sep 27, 2020

Conversation

wickwirew
Copy link
Contributor

@wickwirew wickwirew commented Sep 26, 2020

Adds a publisher for UIControl events. Let me know if there are any changes you would like!

I wasn't sure what to do about the xcodeproj. Just opening the project and adding the file caused a ton of changes that aren't related to my change, and the project doesn't build on my machine without regenerating the project anyways so I omitted those. I can include the regenerated project if you'd like.

@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #27 into main will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   69.34%   69.45%   +0.11%     
==========================================
  Files          26       27       +1     
  Lines         535      537       +2     
==========================================
+ Hits          371      373       +2     
  Misses        164      164              
Impacted Files Coverage Δ
...urces/CombineCocoa/Controls/UIButton+Combine.swift 100.00% <100.00%> (ø)
...rces/CombineCocoa/Controls/UIControl+Combine.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67bd227...21542a7. Read the comment docs.

@freak4pc
Copy link
Member

Looks good, I've renamed it controlEventPublisher and waiting for CI to merge :)

@freak4pc freak4pc merged commit 4de540b into CombineCommunity:main Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants