Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not return ErrSCTE35MissingOut when implicitly closing the only open signal. #113

Merged
merged 2 commits into from
Jan 8, 2019

Conversation

nehashanbhag
Copy link
Collaborator

@nehashanbhag nehashanbhag commented Jan 8, 2019

In VDE, we were seeing an issue where :
#36
/DBLAAEs/S0UAP/wBQb+AAAAAAA1AjNDVUVJT///9X//AACky4AJH1NJR05BTDoyWURWeCtSKzlWc0FBQUFBQUFBQkFRPT02AAD9DXQ/

#37-1 /DBGAAEtT5LUAP/wBQb+AAAAAAAwAi5DVUVJT///9X+/CR9TSUdOQUw6MllEVngrUis5VnNBQUFBQUFBQUJBZz09NwEDU/ktPg==

#35
/DAvAAD5dbEbAP/wBQb+M+6KUwAZAhdDVUVJQAAAPn+fCAgAAAAALecjUzUAALuiqds=

#37-2
/DBGAAEteMW0AP/wBQb+AAAAAAAwAi5DVUVJT///9X+/CR9TSUdOQUw6MllEVngrUis5VnNBQUFBQUFBQUJBdz09NwID1nPQRg==

#37-3
/DBGAAEtofiUAP/wBQb+AAAAAAAwAi5DVUVJT///9X+/CR9TSUdOQUw6MllEVngrUis5VnNBQUFBQUFBQUJCQT09NwMDJVJ1Mg==

0x35 should have closed 0x36, but it doesn't and the period which was created when 0x36 came in, stays forever.

@nehashanbhag
Copy link
Collaborator Author

I tested this using the VDE pcap containing 0x36,0x37,0x35,0x37,0x37 signals and before the fix --the period created by 0x36 was not being removed from the mpd. After the fix the period created by 0x36 was removed and wasn't present in the manifest. I have added a unit test to test this exact same scenario in gots as well.

@mikereedell mikereedell changed the title Pilr1087 bug fix for VDE Do not return ErrSCTE35MissingOut when implicitly closing the only open signal. Jan 8, 2019
@mikereedell
Copy link
Collaborator

Additional documentation for the added unit test:

Before the fix:
0x36 - one open signal
0x37 - nothing closed, one open signal
0x35 - 0x36 closed (and returned), no open signals, ERROR ErrNoMatchingOut
0x37 - nothing closed, no open signals, ERROR ErrNoMatchingOut
0x37- nothing closed, no open signals, ERROR ErrNoMatchingOut

After the fix:
0x36 - one open signal
0x37 - nothing closed, one open signal
0x35 - 0x36 closed (and returned), no open signals, no errors
0x37 - nothing closed, no open signals, ERROR ErrNoMatchingOut
0x37 - nothing closed, no open signals, ERROR ErrNoMatchingOut

The only difference between the two is the fixed code won't return the "ErrMissingOut" when the 0x36 is closed.

@mikereedell mikereedell merged commit c9e8466 into master Jan 8, 2019
@mikereedell mikereedell deleted the pilr1087_VDE branch January 8, 2019 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants