-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EBP creation #96
EBP creation #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phew, finally a shorter one! This generally looks good. There is a lot of code duplication that I'm thinking might be avoided through go type embedding
ebp/doc.go
Outdated
@@ -34,15 +34,77 @@ const ( | |||
CableLabsFormatIdentifier = 0x45425030 | |||
) | |||
|
|||
// cableLabsEbp is an encoder boundary point |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these type and interface definitions be moved to ebp.go? We want to move away from using doc.go like this as it should only be used for documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for addressing the docs changes.
Added support for creating EBPs. Receiver types for EBPs changed to pointers in order to allow for modification. Data function added to convert EBPs back into raw bytes. Added GroupingFlag into EncoderBoundaryPoint interface since it is a common flag between Comcast and Cablelabs EBPs.
Example of new functionality: