Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added swift version preprocessor for using compactMap #24

Merged
merged 1 commit into from
Jun 28, 2018
Merged

added swift version preprocessor for using compactMap #24

merged 1 commit into from
Jun 28, 2018

Conversation

jgainfort
Copy link
Contributor

Description

Adds Swift 4.0 backwards compatibility

Change Notes

Added pre-processor to use deprecated flatMap operator

Pre-submission Checklist

  • I ran the unit tests locally before checking in.
  • I made sure there were no compiler warnings before checking in.
  • [NA] I have written useful documentation for all public code.
  • [NA] I have written unit tests for this new feature.

@CLAassistant
Copy link

CLAassistant commented Jun 28, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jgainfort jgainfort mentioned this pull request Jun 28, 2018
Closed
dcoufal
dcoufal approved these changes Jun 28, 2018
View reviewed changes
Copy link
Contributor

@dcoufal dcoufal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should work. Thank you!

@dcoufal dcoufal merged commit 6ac6d40 into Comcast:develop Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoufal dcoufal dcoufal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgainfort @CLAassistant @dcoufal