Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iOS deployment target to 11, Update Swift version to 5. #61

Merged
merged 3 commits into from
Jun 24, 2019

Conversation

Jesse-calkin
Copy link
Contributor

Description

This PR Updates the iOS deployment target to 11.0, and updates the Swift language version to 5.0

Change Notes

  • Updated the iOS deployment target to 11.0
  • Updated the Swift language version to 5.0

Pre-submission Checklist

  • I ran the unit tests locally before checking in.
  • I made sure there were no compiler warnings before checking in.
  • I have written useful documentation for all public code.
  • I have written unit tests for this new feature.

@dcoufal
Copy link
Contributor

dcoufal commented Jun 24, 2019

@jesse if you are switching to swift 5 you'll probably have to mess around with travis-ci settings to get the correct image. Right now it's failing unit tests as it can't even build.

I can help if it seems mysterious.

Copy link
Contributor

@dcoufal dcoufal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

We'll need a pod file update for 1.3.0 as well.

Copy link
Contributor

@dcoufal dcoufal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@dcoufal dcoufal merged commit 561e35f into develop_1.x Jun 24, 2019
@dcoufal dcoufal deleted the DeploymentTarget-iOS11.0 branch June 24, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants