-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wire instrumentation library info through SpanFactory to SpanInfo #154
Conversation
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
==========================================
- Coverage 94.06% 93.85% -0.21%
==========================================
Files 77 77
Lines 1079 1091 +12
Branches 63 77 +14
==========================================
+ Hits 1015 1024 +9
- Misses 64 67 +3
Continue to review full report at Codecov.
|
Taking WIP off of this PR, I think this approach works and has relatively limited impact on the APIs. TL;DR: The instrumentation library is exposed from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really related but we need to bump the year in the headers
To support SPI scenarios where an instrumentation library will request a tracer with the instrumentation library information which may be used by the span handler/exporter wire the instrumentation library information (name and version) through the CoreSpan and SpanInfo.