Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OTel resource via config and plumb through OtelSpanHandler adapter #196

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

HaloFour
Copy link
Collaborator

@HaloFour HaloFour commented Aug 3, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Merging #196 (54d2ca2) into master (37e1225) will decrease coverage by 0.86%.
The diff coverage is 57.57%.

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
- Coverage   93.96%   93.10%   -0.86%     
==========================================
  Files          94       95       +1     
  Lines        1260     1277      +17     
  Branches       68       70       +2     
==========================================
+ Hits         1184     1189       +5     
- Misses         76       88      +12     
Files Changed Coverage Δ
...src/main/scala/com/comcast/money/core/Tracer.scala 100.00% <ø> (ø)
.../scala/com/comcast/money/core/UnrecordedSpan.scala 10.00% <0.00%> (-4.29%) ⬇️
.../scala/com/comcast/money/wire/SpanConverters.scala 84.04% <0.00%> (-4.73%) ⬇️
...scala/com/comcast/money/core/ResourceFactory.scala 64.28% <64.28%> (ø)
...c/main/scala/com/comcast/money/core/CoreSpan.scala 95.71% <100.00%> (ø)
...scala/com/comcast/money/core/CoreSpanBuilder.scala 94.11% <100.00%> (ø)
...scala/com/comcast/money/core/CoreSpanFactory.scala 100.00% <100.00%> (ø)
...in/scala/com/comcast/money/core/CoreSpanInfo.scala 100.00% <100.00%> (ø)
.../src/main/scala/com/comcast/money/core/Money.scala 88.57% <100.00%> (ø)
...st/money/otel/handlers/MoneyReadableSpanData.scala 96.55% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants