Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SiriusFactory to api package (per issue #11) #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Move SiriusFactory to api package (per issue #11) #23

wants to merge 2 commits into from

Commits on Feb 13, 2014

  1. Move SiriusFactory to sirius package 

    SiriusFactory is the only way to create instances of Sirius, so logically
it belongs in the public API. That should be in the top-level sirius
package.
    @smuir
    smuir committed Feb 13, 2014
    Configuration menu
    Copy the full SHA
    88c9a1b View commit details
    Browse the repository at this point in the history

  2. Make top-level class be primary 

    Move implementation of SiriusFactory to the top-level package, the
existing class in api.impl just wraps that class and is marked
deprecated.
    @smuir
    smuir committed Feb 13, 2014
    Configuration menu
    Copy the full SHA
    bf02581 View commit details
    Browse the repository at this point in the history