Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

feat: add sentence validator for catalan #606

Merged
merged 4 commits into from
Feb 19, 2022
Merged

feat: add sentence validator for catalan #606

merged 4 commits into from
Feb 19, 2022

Conversation

jmigual
Copy link
Contributor

@jmigual jmigual commented Feb 19, 2022

Uses the gersam tokenizer for Catalan that counts a word with a dash as a single word.

@jmigual jmigual changed the title Add sentence validator for catalan feat: add sentence validator for catalan Feb 19, 2022
MichaelKohler
MichaelKohler suggested changes Feb 19, 2022
View reviewed changes
Copy link
Member

@MichaelKohler MichaelKohler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this. Generally looks good to me, just 2 things to comment on.

server/lib/validation/index.js Outdated Show resolved Hide resolved
server/lib/validation/index.js Outdated Show resolved Hide resolved
server/lib/validation/languages/ca.js Outdated Show resolved Hide resolved
@jmigual
Copy link
Contributor Author

jmigual commented Feb 19, 2022

Sure I'll solve it right away

@jmigual
Copy link
Contributor Author

jmigual commented Feb 19, 2022

Issues fixed

MichaelKohler
MichaelKohler approved these changes Feb 19, 2022
View reviewed changes
Copy link
Member

@MichaelKohler MichaelKohler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This will be part of the next Sentence Collector release. Once that happens, there will be a new comment on this PR.

@MichaelKohler MichaelKohler merged commit 1096aef into common-voice:main Feb 19, 2022
MichaelKohler pushed a commit that referenced this pull request Feb 20, 2022
@semantic-release-bot
chore(release): 2.17.0
ebaab97 
# [2.17.0](v2.16.4...v2.17.0) (2022-02-20)

### Bug Fixes

* add sentence validator for Cantonese ([#605](#605)) ([18fa4b2](18fa4b2))
* remove certain sentences for tok language ([#607](#607)) ([7aa6ad7](7aa6ad7))

### Features

* add sentence validator for catalan ([#606](#606)) ([1096aef](1096aef))
@MichaelKohler
Copy link
Member

🎉 This PR is included in version 2.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichaelKohler MichaelKohler MichaelKohler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmigual @MichaelKohler