Add dynamic user configuration to image. #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jdcasey
approved these changes
May 30, 2020
|
The changes added in this PR do not implement the desired behaviour. |
|
There additional changes necessary for the nss_wrapper to be recognized correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the issue #21
This PR looks to add nss_wrapper module to the image. Allowing Openshift to add a user with a dynamic id and the image still recognizing the Dockerfile selected user.
This is done by re-writing the passwd file with the id. A template passwd file is included and added to the image. This is populated at runtime with the new id of the user.
The call to dumb-init has been updated to call the setup-user.sh bash script before starting the jvm process. Using the technique to call additional bash scripts documented in the dumb-init repository.