Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extension methods for SetAppTheme and SetAppThemeColor #118

Merged
merged 28 commits into from
Nov 2, 2022

Conversation

fredericoregateiro
Copy link
Contributor

@fredericoregateiro fredericoregateiro commented Sep 20, 2022

Description of Change

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: Added app theme docs MicrosoftDocs/CommunityToolkit#157

Additional information

@brminnick
Copy link
Collaborator

Thanks @fredericoregateiro!

Your Proposal Champion is @bijington and he will help guide you through the New Feature Proposal Process.

The Proposal for this feature, #117, must first be approved by the core maintainer team before we can review, approve and merge this PR. Shaun will bring this feature to a vote at our upcoming Monthly Standup meeting this Thursday.

After it is approved, we'll also need you to write the Docs by opening a PR on our Docs repo: https://github.com/MicrosoftDocs/CommunityToolkit/

I did take a quick look at this PR and noticed a few things missing:

  • Add Unit Tests
  • Update the Sample App to display the use of the new feature.

Thanks again for your hard work!

@fredericoregateiro
Copy link
Contributor Author

Thanks @brminnick
I'll be updating those taks as soon as i can

@bijington
Copy link
Contributor

Thanks @brminnick
I'll be updating those taks as soon as i can

Thanks @fredericoregateiro, do let me know if you need any assistance with the tasks as I am here to assist in any way 👍

@bijington bijington enabled auto-merge (squash) October 30, 2022 13:19
@jfversluis
Copy link
Member

Docs are ready to go afaic

Copy link
Collaborator

@brminnick brminnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good!!!

I just have a concern about the method name, Style<T>.Add() because it is so similar to the existing Add that devs may accidentally use it + confuse for the existing API, not fully understanding that it is explicitly creating a new AppThemeBinding

@brminnick brminnick added the hacktoberfest-accepted A PR that has been approved during Hacktoberfest label Oct 31, 2022
Copy link
Collaborator

@brminnick brminnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

Thanks so much @fredericoregateiro + @bijington!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted A PR that has been approved during Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants