-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add extension methods for SetAppTheme and SetAppThemeColor #118
add extension methods for SetAppTheme and SetAppThemeColor #118
Conversation
Thanks @fredericoregateiro! Your Proposal Champion is @bijington and he will help guide you through the New Feature Proposal Process. The Proposal for this feature, #117, must first be approved by the core maintainer team before we can review, approve and merge this PR. Shaun will bring this feature to a vote at our upcoming Monthly Standup meeting this Thursday. After it is approved, we'll also need you to write the Docs by opening a PR on our Docs repo: https://github.com/MicrosoftDocs/CommunityToolkit/ I did take a quick look at this PR and noticed a few things missing:
Thanks again for your hard work! |
Thanks @brminnick |
Thanks @fredericoregateiro, do let me know if you need any assistance with the tasks as I am here to assist in any way 👍 |
This reverts commit f408749.
Docs are ready to go afaic |
```cs where TBindable : BindableObject ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good!!!
I just have a concern about the method name, Style<T>.Add()
because it is so similar to the existing Add
that devs may accidentally use it + confuse for the existing API, not fully understanding that it is explicitly creating a new AppThemeBinding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
Thanks so much @fredericoregateiro + @bijington!!!
Description of Change
Linked Issues
[Proposal] Extension bindings for AppTheme and AppThemeColor #117
PR Checklist
approved
(bug) orChampioned
(feature/proposal)main
at time of PRAdditional information