Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make All Generated Classes internal #159

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Conversation

brminnick
Copy link
Collaborator

@brminnick brminnick commented Nov 28, 2022

Description of Change

This PR changes generated classes, i.e. code generated by TextAlignmentExtensionsGenerator, from public to internal.

The bug in #158 is caused by two matching public classes being generated in both the .NET MAUI library (eg net7.0-ios) and the referenced class library (e.g. net7.0).

📦MyMauiSolution
 ┣ 📂MyMauiApp
    - <TargetFrameworks>net7.0-android;net7.0-ios;net7.0-maccatalyst</TargetFrameworks>
 ┗ 📂MyLibrary
    - <TargetFramework>net7.0</TargetFramework>

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard

Additional information

This aligns with a similar discussion on the CommunityToolkit.Maui repo: CommunityToolkit/Maui#756 (comment)

@brminnick brminnick changed the title Update TextAlignmentExtensionsGenerator.cs Make All Generated Classes internal Nov 28, 2022
@brminnick
Copy link
Collaborator Author

@brminnick brminnick marked this pull request as ready for review November 28, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants