-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for IValueConverter
in Typed Bindings Extensions
#183
Add Support for IValueConverter
in Typed Bindings Extensions
#183
Conversation
@bijington Are you able to update the docs for this PR? I know you've already got a list of the binding examples that couldn't be updated when we implemented #155. |
i value converter
in .bind()
with typed biningsIValueConverter
in Typed Bindings Extensions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @brminnick. There is just the minor comment around the unit test code but we probably don't need to change that
src/CommunityToolkit.Maui.Markup.UnitTests/TypedBindingExtensionsTests.cs
Show resolved
Hide resolved
Thanks Shaun! I agree that we could reuse the code in the Unit Test, but to be honest I've found it a bit of an anti-pattern to try and share code between Unit Tests. I copy/pasted Thanks for helping with the Docs! I'll wait to merge this PR until we have a Docs PR queued up. |
Here you go: MicrosoftDocs/CommunityToolkit#226 |
Description of Change
This PR adds support for
IValueConverter
with Typed Bindings extensionsLinked Issues
Bind
typed binding support to provideIValueConverter
support #179PR Checklist
approved
(bug) orChampioned
(feature/proposal)main
at time of PRAdditional information
Allows the use of
IValueConverter
with the new Typed Bindings extensions, such asCommunityToolkit.Maui.Converters.ColorToHexRgbStringConverter
in the .NET MAUI Community Toolkit: