Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tooling #139

Merged
merged 4 commits into from
Jul 18, 2023
Merged

Update tooling #139

merged 4 commits into from
Jul 18, 2023

Conversation

niels9001
Copy link
Collaborator

No description provided.

@Arlodotexe
Copy link
Member

Arlodotexe commented Jul 13, 2023

@niels9001 The issue occurring in this build will be fixed by #113 (comment)

@niels9001 niels9001 added the documentation Improvements or additions to documentation label Jul 14, 2023
@michael-hawker
Copy link
Member

I'm updating the tooling to the latest in #138 as well, so don't think we need this?

@michael-hawker michael-hawker marked this pull request as draft July 18, 2023 21:56
@Arlodotexe
Copy link
Member

Arlodotexe commented Jul 18, 2023

This PR is ready to go, #138 seems like it has extra baggage that we don't need. Other PRs will need to update the submodule for other reasons (e.g. #151 needs a tooling fix that hasn't merged yet), but it's fine if they all update it.

The submodule pointer is being moved to the same place, this PR gets it in earlier so we're working with the latest now on new PRs instead of waiting until #138 closes.

@Arlodotexe Arlodotexe marked this pull request as ready for review July 18, 2023 22:15
@Arlodotexe Arlodotexe merged commit aeb84d9 into main Jul 18, 2023
@delete-merged-branch delete-merged-branch bot deleted the niels9001/updatetooling branch July 18, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants