fix: ssg_test_suite: warning when rule not in benchmark #10642
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When rule selected to be tested is not in benchmark, issue
WARNING
, notERROR
.Rationale:
ERROR message just confuses most of time and the situation is not something that can be fixed. It is lack of configuration. I think warning is better choice.
In many cases Automatus tests fail because it checks
ERROR
string in log.For example now: #10600 there is the case.
Review Hints:
I'm not sure if this is the way to fix the issue. Maybe testing rule selection algorithm should not not select rules not in benchmarks. Warnings are still visible in logs.