Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ssg_test_suite: warning when rule not in benchmark #10642

Merged
merged 1 commit into from
May 30, 2023

Conversation

maage
Copy link
Contributor

@maage maage commented May 28, 2023

Description:

When rule selected to be tested is not in benchmark, issue WARNING, not ERROR.

Rationale:

ERROR message just confuses most of time and the situation is not something that can be fixed. It is lack of configuration. I think warning is better choice.

In many cases Automatus tests fail because it checks ERROR string in log.

For example now: #10600 there is the case.

Review Hints:

I'm not sure if this is the way to fix the issue. Maybe testing rule selection algorithm should not not select rules not in benchmarks. Warnings are still visible in logs.

ERROR message just confuses most of time and the situation is not
something that can be fixed. It is lack of configuration. I think
warning is better choice.
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label May 28, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 28, 2023

Hi @maage. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented May 28, 2023

Code Climate has analyzed commit 8440a09 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.5% (0.0% change).

View more on Code Climate.

@vojtapolasek vojtapolasek self-assigned this May 30, 2023
@vojtapolasek
Copy link
Collaborator

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels May 30, 2023
@marcusburghardt marcusburghardt added this to the 0.1.69 milestone May 30, 2023
@marcusburghardt marcusburghardt added enhancement General enhancements to the project. Test Suite Update in Test Suite. labels May 30, 2023
Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @maage, this looks reasonable. I think it will make the upstream PR reviewing process easier.

@vojtapolasek vojtapolasek merged commit 4a054c1 into ComplianceAsCode:master May 30, 2023
32 checks passed
@maage maage deleted the error-1 branch June 20, 2023 12:04
@maage
Copy link
Contributor Author

maage commented Jun 20, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancements to the project. ok-to-test Used by openshift-ci bot. Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants