-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defined notes and rules for BSI APP.4.4.A18 #12154
base: master
Are you sure you want to change the base?
Defined notes and rules for BSI APP.4.4.A18 #12154
Conversation
Hi @benruland. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2fa7ea1
to
2bb18f7
Compare
This datastream diff is auto generated by the check Click here to see the full diffNew content has different text for rule 'xccdf_org.ssgproject.content_rule_configure_network_policies'.
--- xccdf_org.ssgproject.content_rule_configure_network_policies
+++ xccdf_org.ssgproject.content_rule_configure_network_policies
@@ -52,6 +52,9 @@
APP.4.4.A7
[reference]:
+APP.4.4.A18
+
+[reference]:
SYS.1.6.A5
[reference]:
New content has different text for rule 'xccdf_org.ssgproject.content_rule_configure_network_policies_namespaces'.
--- xccdf_org.ssgproject.content_rule_configure_network_policies_namespaces
+++ xccdf_org.ssgproject.content_rule_configure_network_policies_namespaces
@@ -133,6 +133,9 @@
APP.4.4.A7
[reference]:
+APP.4.4.A18
+
+[reference]:
SYS.1.6.A5
[reference]:
New content has different text for rule 'xccdf_org.ssgproject.content_rule_project_config_and_template_network_policy'.
--- xccdf_org.ssgproject.content_rule_project_config_and_template_network_policy
+++ xccdf_org.ssgproject.content_rule_project_config_and_template_network_policy
@@ -38,6 +38,9 @@
APP.4.4.A7
[reference]:
+APP.4.4.A18
+
+[reference]:
CNTR-OS-000110
[reference]: |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
applications/openshift/networking/configure_appropriate_network_policies/rule.yml
Outdated
Show resolved
Hide resolved
applications/openshift/networking/configure_appropriate_network_policies/rule.yml
Outdated
Show resolved
Hide resolved
applications/openshift/networking/configure_appropriate_network_policies/rule.yml
Outdated
Show resolved
Hide resolved
applications/openshift/networking/configure_appropriate_network_policies/rule.yml
Show resolved
Hide resolved
092385a
to
e5f48b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@benruland I think you'll need to rebase to latest master so that CI runs appropriately
/packit test |
e5f48b6
to
b85f0f6
Compare
Alright, I just rebased it. Should be fine now |
Code Climate has analyzed commit b85f0f6 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 60.9% (0.0% change). View more on Code Climate. |
Description:
Notes / Rules for BSI APP4.4.A17
Rationale:
As we have multiple customers asking for a BSI profile to be included in the compliance-operator, we are contributing a profile. To provide a better review process, the individual controle are implemented as separate PRs.
This is a follow-up of #11659. It was breaken up for better reviewability.