-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CU-35txqkb] Removed AR Overwrite of ED #2281
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Task linked: CU-35txqkb Update multi_existential_deposits |
Nix commands for this PRNOTE: You can also run our Nix commands in Docker. See the bottom of this comment. Make sure you have setup the Composable community cache:(you only need to run it once on your machine) nix-shell -p cachix --command "cachix use composable-community" Show all possible apps, shells and packages:
Run the Composable node alone:nix run "github:ComposableFi/composable/85eb69c136e5b3d92973f4cca8368592b3aecaf5#composable-node" -L Spin up a local devnet:nix run "github:ComposableFi/composable/85eb69c136e5b3d92973f4cca8368592b3aecaf5#devnet" -L --option sandbox relaxed --show-trace Spin up a local XCVM devnet:nix run "github:ComposableFi/composable/85eb69c136e5b3d92973f4cca8368592b3aecaf5#devnet-xcvm" -L View the docs:nix run ".#docs-server" Run this without Nix in Docker.docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/85eb69c136e5b3d92973f4cca8368592b3aecaf5#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes" NOTE: You can swap For more info on how to use Nix, check out our Nix docs Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported. |
eaf34c1
to
40cb1a9
Compare
Visit the preview URL for this PR (updated for commit 40cb1a9): https://picasso-f0d16--pr2281-connor-cu-35txqkb-no-44iotemh.web.app (expires Tue, 22 Nov 2022 14:42:34 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d4e030ec330173845b1768cd217beee9791d20f1 |
Visit the preview URL for this PR (updated for commit 40cb1a9): https://pablo-afa5d--pr2281-connor-cu-35txqkb-no-bjp5anx5.web.app (expires Tue, 22 Nov 2022 14:42:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 8ef316967fc7aa470dc109d617260c43c009e4e3 |
Anticipating needing to resolve merge conflicts and retest after #2313 |
40cb1a9
to
ece46ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove/modify storage modifications. Let's create tickets to do that with a later release and a data migration which drains storage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's track the later migration to remove AssetEd
for later, in clickup
Issue
[CU-35txqkb]
[CU-35txtwh]
Additional Changes
WellKnownForeignToNativePriceConverter::to_asset_balance()
now returnsNone
instead ofBalance::one()
when encountering anArithmeticError