Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CU-35txqkb] Removed AR Overwrite of ED #2281

Merged
merged 4 commits into from
Nov 16, 2022

Conversation

PoisonPhang
Copy link
Contributor

@PoisonPhang PoisonPhang commented Nov 11, 2022

Issue

[CU-35txqkb]
[CU-35txtwh]

Additional Changes

  • WellKnownForeignToNativePriceConverter::to_asset_balance() now returns None instead of Balance::one() when encountering an ArithmeticError
  • Currency Factory no longer accepts or tracks ED when creating or storing assets. Given that the storage map for ED was independent of any other storage items, it should not need any storage migrations when getting removed.

@vercel
Copy link

vercel bot commented Nov 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pablo-staging ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 3:36PM (UTC)
picasso-nightly ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 3:36PM (UTC)

@itsbobbyzz
Copy link

@github-actions
Copy link

github-actions bot commented Nov 11, 2022

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/85eb69c136e5b3d92973f4cca8368592b3aecaf5 --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/85eb69c136e5b3d92973f4cca8368592b3aecaf5#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/85eb69c136e5b3d92973f4cca8368592b3aecaf5#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/85eb69c136e5b3d92973f4cca8368592b3aecaf5#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/85eb69c136e5b3d92973f4cca8368592b3aecaf5#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package

For more info on how to use Nix, check out our Nix docs

Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

@vercel vercel bot temporarily deployed to Preview – pablo-staging November 11, 2022 21:53 Inactive
@vercel vercel bot temporarily deployed to Preview – pablo-staging November 13, 2022 16:16 Inactive
@vercel vercel bot temporarily deployed to Preview – pablo-staging November 13, 2022 16:52 Inactive
@PoisonPhang PoisonPhang marked this pull request as ready for review November 14, 2022 18:21
@PoisonPhang PoisonPhang requested a review from a team November 14, 2022 18:21
@PoisonPhang PoisonPhang requested review from a team as code owners November 14, 2022 21:29
@vercel vercel bot temporarily deployed to Preview – pablo-staging November 14, 2022 21:38 Inactive
@PoisonPhang PoisonPhang marked this pull request as draft November 14, 2022 22:48
@PoisonPhang PoisonPhang force-pushed the connor/CU-35txqkb_no-AR-overwrite branch from eaf34c1 to 40cb1a9 Compare November 15, 2022 00:37
@vercel vercel bot temporarily deployed to Preview – pablo-staging November 15, 2022 00:42 Inactive
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 40cb1a9):

https://picasso-f0d16--pr2281-connor-cu-35txqkb-no-44iotemh.web.app

(expires Tue, 22 Nov 2022 14:42:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d4e030ec330173845b1768cd217beee9791d20f1

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 40cb1a9):

https://pablo-afa5d--pr2281-connor-cu-35txqkb-no-bjp5anx5.web.app

(expires Tue, 22 Nov 2022 14:42:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8ef316967fc7aa470dc109d617260c43c009e4e3

@PoisonPhang PoisonPhang marked this pull request as ready for review November 15, 2022 14:44
@PoisonPhang PoisonPhang requested a review from a team as a code owner November 15, 2022 14:44
@PoisonPhang
Copy link
Contributor Author

Anticipating needing to resolve merge conflicts and retest after #2313

@PoisonPhang PoisonPhang force-pushed the connor/CU-35txqkb_no-AR-overwrite branch from 40cb1a9 to ece46ae Compare November 15, 2022 18:27
@vercel vercel bot temporarily deployed to Preview – pablo-staging November 15, 2022 18:32 Inactive
Copy link
Contributor

@vimukthi-git vimukthi-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove/modify storage modifications. Let's create tickets to do that with a later release and a data migration which drains storage.

code/parachain/frame/currency-factory/src/lib.rs Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – pablo-staging November 16, 2022 15:30 Inactive
@vercel vercel bot temporarily deployed to Preview – picasso-nightly November 16, 2022 15:36 Inactive
Copy link
Contributor

@vimukthi-git vimukthi-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's track the later migration to remove AssetEd for later, in clickup

mergify bot added a commit that referenced this pull request Nov 16, 2022
@mergify mergify bot merged commit b3ead07 into main Nov 16, 2022
@mergify mergify bot deleted the connor/CU-35txqkb_no-AR-overwrite branch November 16, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants