[CU-3t3ay05] Add ratio and ED to assets RPC #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Task linked: CU-3t3ay05 Add ratio and ED to assets RPC |
Nix commands for this PRNOTE: You can also run our Nix commands in Docker. See the bottom of this comment. Make sure you have setup the Composable community cache:(you only need to run it once on your machine) nix-shell -p cachix --command "cachix use composable-community"Show all possible apps, shells and packages:Run the Composable node alone:nix run "github:ComposableFi/composable/f16718117ea981f9e0e76ad856b9dfd3f066d5a1#composable-node" -LSpin up a local devnet:nix run "github:ComposableFi/composable/f16718117ea981f9e0e76ad856b9dfd3f066d5a1#devnet" -L --option sandbox relaxed --show-traceSpin up a local XCVM devnet:nix run "github:ComposableFi/composable/f16718117ea981f9e0e76ad856b9dfd3f066d5a1#devnet-xcvm" -LView the docs:nix run ".#docs-server"Run this without Nix in Docker.docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/f16718117ea981f9e0e76ad856b9dfd3f066d5a1#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"NOTE: You can swap For more info on how to use Nix, check out our Nix docs Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported. |
andresmechali
force-pushed
the
andres/add-ratio-and-ed-to-assets-rpc
branch
from
e9ce987
to
54de9c2
Compare
andresmechali
force-pushed
the
andres/add-ratio-and-ed-to-assets-rpc
branch
from
54de9c2
to
d780935
Compare
andresmechali
force-pushed
the
andres/add-ratio-and-ed-to-assets-rpc
branch
from
d780935
to
2dc5d0c
Compare
andresmechali
force-pushed
the
andres/add-ratio-and-ed-to-assets-rpc
branch
2 times, most recently
from
7212682
to
9b1e19b
Compare
andresmechali
requested review from
easteregg,
vimukthi-git and
obsessed-cake
code/integration-tests/runtime-tests/test/tests/assets/rpcAssetsTests.ts
Outdated
Show resolved
Hide resolved
dzmitry-lahoda
approved these changes
Nov 15, 2022
andresmechali
force-pushed
the
andres/add-ratio-and-ed-to-assets-rpc
branch
from
79cdd92
to
f167181
Compare
easteregg
approved these changes
Nov 17, 2022
|
@mergify refresh |
✅ Pull request refreshed |
dzmitry-lahoda
approved these changes
Nov 17, 2022
vimukthi-git
approved these changes
Nov 18, 2022
|
@mergify refresh |
✅ Pull request refreshed |
kollegian
approved these changes
Nov 18, 2022
code/integration-tests/runtime-tests/test/tests/assets/rpcAssetsTests.ts
Show resolved
Hide resolved
Dominique-Roth
approved these changes
Nov 18, 2022
|
@mergify refresh |
✅ Pull request refreshed |
85 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://app.clickup.com/t/3t3ay05
I will keep this open until #2281 has been merged, as some minor changes will need to be made