Pablo DEX refactor: add & remove liquidity #2575

benluelo · 2022-12-06T15:35:04Z

https://app.clickup.com/t/30xvvdj
https://app.clickup.com/t/30xvvdg

itsbobbyzz · 2022-12-06T15:35:07Z

Task linked: CU-30xvvdg 5.3) 6. Implement Algorithm: Amm::add_liquidity.

vercel · 2022-12-06T15:36:12Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Updated
pablo-nightly	⬜️ Ignored (Inspect)		Dec 12, 2022 at 9:02PM (UTC)
picasso-nightly	⬜️ Ignored (Inspect)		Dec 12, 2022 at 9:02PM (UTC)

github-actions · 2022-12-06T15:36:54Z

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/4abeb644805b21d27732c68ca2e5c6142da51969 --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/4abeb644805b21d27732c68ca2e5c6142da51969#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/4abeb644805b21d27732c68ca2e5c6142da51969#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/4abeb644805b21d27732c68ca2e5c6142da51969#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/4abeb644805b21d27732c68ca2e5c6142da51969#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package
For more info on how to use Nix, check out our Nix docs
Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

code/parachain/frame/pablo/src/lib.rs

github-actions · 2022-12-06T16:52:51Z

Visit the preview URL for this PR (updated for commit 6f1c48a):

https://picasso-f0d16--pr2575-ben-refactor-amm-add-l9qiopcz.web.app

_{(expires Tue, 13 Dec 2022 16:52:42 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: d4e030ec330173845b1768cd217beee9791d20f1}

github-actions · 2022-12-06T16:53:09Z

Visit the preview URL for this PR (updated for commit 6f1c48a):

https://pablo-afa5d--pr2575-ben-refactor-amm-add-ol04lvrs.web.app

_{(expires Tue, 13 Dec 2022 16:53:00 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 8ef316967fc7aa470dc109d617260c43c009e4e3}

code/parachain/frame/composable-traits/src/dex.rs

code/parachain/frame/pablo/proptest-regressions/dual_asset_constant_product_tests.txt

code/parachain/frame/pablo/src/dual_asset_constant_product.rs

code/parachain/frame/composable-maths/src/dex/constant_product.rs

code/parachain/frame/composable-maths/src/dex/mod.rs

code/parachain/frame/pablo/src/dual_asset_constant_product.rs

code/parachain/frame/pablo/src/test/dual_asset_constant_product_tests_new.rs

code/parachain/frame/pablo/src/test/dual_asset_constant_product_tests.rs

code/parachain/frame/composable-maths/src/dex/mod.rs

wip wip wip wip

* Added R2 LP Tokens * Added LPT to Pablo Interface * Removed mintable token from extrinsic * Added Pablo to Picasso Runtime * Revert "Removed mintable token from extrinsic" This reverts commit 5f766b4. * Revert "Revert "Removed mintable token from extrinsic"" This reverts commit 9d0ffc3. * Added supporting methods for migration * Use btree macro * Use Vector * Moved to Dali for testing * Removed Pablo from Picasso * Use 0.3% * Use benchmarked weights * method only generated one pool at a time * Added migration tests * Ensure migration does not create duplicates * Reverse logic

code/parachain/frame/pablo/src/dual_asset_constant_product.rs

code/parachain/frame/pablo/src/lib.rs

PoisonPhang · 2022-12-12T23:05:20Z

@Mergifyio refresh

mergify · 2022-12-12T23:05:56Z

refresh

✅ Pull request refreshed

KaiserKarel · 2022-12-13T00:41:45Z

@Mergifyio refresh

mergify · 2022-12-13T00:42:22Z

refresh

✅ Pull request refreshed

KaiserKarel · 2022-12-13T00:46:28Z

@Mergifyio refresh

mergify · 2022-12-13T00:47:04Z

refresh

✅ Pull request refreshed

PoisonPhang · 2022-12-13T01:16:59Z

https://github.com/Mergifyio refresh

mergify · 2022-12-13T01:17:34Z

refresh

✅ Pull request refreshed

benluelo requested review from a team as code owners December 6, 2022 15:35

benluelo requested review from easteregg, seunlanlege and obsessed-cake December 6, 2022 15:35

benluelo changed the title ~~Ben/refactor amm add liquidy/#30xvvdg~~ Pablo DEX refactor: add & remove liquidity Dec 6, 2022

benluelo commented Dec 6, 2022

View reviewed changes

code/parachain/frame/pablo/src/lib.rs Show resolved Hide resolved

PoisonPhang reviewed Dec 6, 2022

View reviewed changes

benluelo force-pushed the ben/refactor-amm-add-liquidy/#30xvvdg branch from 6c8d4cc to cc38e23 Compare December 6, 2022 18:09

PoisonPhang approved these changes Dec 6, 2022

View reviewed changes

vimukthi-git reviewed Dec 6, 2022

View reviewed changes

code/parachain/frame/pablo/src/test/dual_asset_constant_product_tests_new.rs Show resolved Hide resolved

vimukthi-git reviewed Dec 6, 2022

View reviewed changes

code/parachain/frame/pablo/src/test/dual_asset_constant_product_tests.rs Show resolved Hide resolved

vimukthi-git reviewed Dec 6, 2022

View reviewed changes

code/parachain/frame/pablo/src/test/dual_asset_constant_product_tests.rs Show resolved Hide resolved

benluelo force-pushed the ben/refactor-amm-add-liquidy/#30xvvdg branch from cc38e23 to afae9dc Compare December 6, 2022 18:42

benluelo requested review from a team as code owners December 6, 2022 18:42

benluelo requested a review from a team December 6, 2022 18:42

benluelo requested review from a team as code owners December 6, 2022 18:42

benluelo mentioned this pull request Dec 6, 2022

Fix compute_first_deposit_lp #2572

Closed

benluelo commented Dec 6, 2022

View reviewed changes

code/parachain/frame/composable-maths/src/dex/mod.rs Show resolved Hide resolved

Fix compute_first_deposit_lp

e258cba

benluelo force-pushed the ben/refactor-amm-add-liquidy/#30xvvdg branch from 16f8247 to e421606 Compare December 6, 2022 18:54

wip

2de900c

wip wip wip wip

hussein-aitlahcen approved these changes Dec 8, 2022

View reviewed changes

Dominique-Roth approved these changes Dec 9, 2022

View reviewed changes

benluelo added 2 commits December 9, 2022 18:24

dex router tests are passing

406ba7a

fixed tests (hopefully) (maybe)

c78add5

Martin-Kiss requested a review from KaiserKarel December 12, 2022 10:26

PoisonPhang requested a review from a team December 12, 2022 15:57

Spelling

cec665f

vimukthi-git reviewed Dec 12, 2022

View reviewed changes

code/parachain/frame/pablo/src/dual_asset_constant_product.rs Show resolved Hide resolved

PoisonPhang added 2 commits December 12, 2022 10:37

Move second deposit to if std block

80849a8

Remove debug assertion

023feb0

PoisonPhang force-pushed the ben/refactor-amm-add-liquidy/#30xvvdg branch from c5fb4d6 to 023feb0 Compare December 12, 2022 17:35

PoisonPhang added 2 commits December 12, 2022 12:18

Remove dbg macro

771dc13

Remove std elements from benchmarks

4a63ab8

vimukthi-git reviewed Dec 12, 2022

View reviewed changes

code/parachain/frame/pablo/src/lib.rs Outdated Show resolved Hide resolved

PoisonPhang added 3 commits December 12, 2022 14:18

BTree Macro does not work in no-std

c12adf2

Use second deposit value

818b353

Removed unused min expected value

4abeb64

mergify bot added a commit that referenced this pull request Dec 13, 2022

Merge of #2575

e854498

mergify bot mentioned this pull request Dec 13, 2022

merge-queue: embarking main (470f8cc) and #2575 together #2663

Closed

KaiserKarel merged commit 01fba50 into main Dec 13, 2022

KaiserKarel deleted the ben/refactor-amm-add-liquidy/#30xvvdg branch December 13, 2022 01:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pablo DEX refactor: add & remove liquidity #2575

Pablo DEX refactor: add & remove liquidity #2575

benluelo commented Dec 6, 2022 •

edited

itsbobbyzz commented Dec 6, 2022

vercel bot commented Dec 6, 2022 •

edited

github-actions bot commented Dec 6, 2022 •

edited

github-actions bot commented Dec 6, 2022

github-actions bot commented Dec 6, 2022

PoisonPhang commented Dec 12, 2022

mergify bot commented Dec 12, 2022

KaiserKarel commented Dec 13, 2022

mergify bot commented Dec 13, 2022

KaiserKarel commented Dec 13, 2022

mergify bot commented Dec 13, 2022

PoisonPhang commented Dec 13, 2022

mergify bot commented Dec 13, 2022

Pablo DEX refactor: add & remove liquidity #2575

Pablo DEX refactor: add & remove liquidity #2575

Conversation

benluelo commented Dec 6, 2022 • edited

itsbobbyzz commented Dec 6, 2022

vercel bot commented Dec 6, 2022 • edited

github-actions bot commented Dec 6, 2022 • edited

Nix commands for this PR

Make sure you have setup the Composable community cache:

Show all possible apps, shells and packages:

Run the Composable node alone:

Spin up a local devnet:

Spin up a local XCVM devnet:

View the docs:

Run this without Nix in Docker.

github-actions bot commented Dec 6, 2022

github-actions bot commented Dec 6, 2022

PoisonPhang commented Dec 12, 2022

mergify bot commented Dec 12, 2022

✅ Pull request refreshed

KaiserKarel commented Dec 13, 2022

mergify bot commented Dec 13, 2022

✅ Pull request refreshed

KaiserKarel commented Dec 13, 2022

mergify bot commented Dec 13, 2022

✅ Pull request refreshed

PoisonPhang commented Dec 13, 2022

mergify bot commented Dec 13, 2022

✅ Pull request refreshed

benluelo commented Dec 6, 2022 •

edited

vercel bot commented Dec 6, 2022 •

edited

github-actions bot commented Dec 6, 2022 •

edited