[Pablo] Provide LPT when creating pools [CU-3916rnu]#2624
Merged
PoisonPhang merged 18 commits intoben/refactor-amm-add-liquidy/#30xvvdgfrom Dec 12, 2022
Merged
[Pablo] Provide LPT when creating pools [CU-3916rnu]#2624PoisonPhang merged 18 commits intoben/refactor-amm-add-liquidy/#30xvvdgfrom
PoisonPhang merged 18 commits intoben/refactor-amm-add-liquidy/#30xvvdgfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
vimukthi-git
reviewed
Dec 9, 2022
Contributor
vimukthi-git
left a comment
vimukthi-git
left a comment
There was a problem hiding this comment.
LGTM overall, but unfortunately we can't use Picasso for testing. Let's use Dali for now and we can introduce Picasso version in a second PR as it's the first time we are adding Pablo to Picasso runtime.
vimukthi-git
reviewed
Dec 9, 2022
benluelo
changed the title
benluelo
reviewed
Dec 9, 2022
PoisonPhang
force-pushed
the
connor/provide-lpt-to-pablo
branch
from
03a4a44 to
27fb681
Compare
PoisonPhang
commented
Dec 9, 2022
vimukthi-git
reviewed
Dec 9, 2022
vimukthi-git
approved these changes
Dec 12, 2022
KaiserKarel
approved these changes
Dec 12, 2022
PoisonPhang
commented
Dec 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
[CU-3916rnu]
Additional Changes
Wrapping the LPT ID in an option for future proofing - also has the potential to expose more to testers.