Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detecting addressee in letters in Mentions folders #42

Closed
LucasHorseshoeBend opened this issue Dec 20, 2017 · 2 comments
Closed

Detecting addressee in letters in Mentions folders #42

LucasHorseshoeBend opened this issue Dec 20, 2017 · 2 comments

Comments

@LucasHorseshoeBend
Copy link
Collaborator

For when you get funds:
Example file:
http://vmcp.conaltuohy.com/xtf/view?docId=tei/Mentions/Selected Mentions letters/M52-10-08-final.xml
I noticed a problem with mentions letters coming up with Mueller as the author; we fixed it by starting the correspondent line with From. The Author facet now helpfully shows up as, for example, "Charles La Trobe to Ronald Gunn". But the Addressee facet for these files shows "Ferdinand von Mueller".

I suspect that the algorithm needs to be tweaked to check for to in the text of the correspondent style, so that the part of it after to is identified as the Addressee. It would be a pity to lose the current identification of correspondent for these files which shows up everything after From, but if we have to, then it's a price I think worth paying to prevent Mueller being the default Addressee.

@Conal-Tuohy
Copy link
Owner

this has been done, and should've been closed a while ago

@LucasHorseshoeBend
Copy link
Collaborator Author

LucasHorseshoeBend commented Feb 17, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants