Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetBakersRewardPeriod gives incorrect data #1176

Closed
td202 opened this issue May 27, 2024 · 1 comment · Fixed by #1209
Closed

GetBakersRewardPeriod gives incorrect data #1176

td202 opened this issue May 27, 2024 · 1 comment · Fixed by #1209
Assignees
Labels
[Type] Bug Something isn't working

Comments

@td202
Copy link
Contributor

td202 commented May 27, 2024

Bug Description

The GetBakersRewardPeriod gives incorrect data concerning the pool commission rates, baker equity capital and delegated capital. The values presented are based on the active staking, whereas they should be based on the staking that applies to the current epoch (i.e. the snapshot of the active values that was taken one epoch before the last payday).

Steps to Reproduce

Compare the results from GetBakersRewardPeriod (aka GetValidatorsRewardPeriod in the client) and GetPoolInfo.

Expected Result

  • equityCapital should match currentPaydayStatus/bakerEquityCapital
  • commissionRates should match currentPaydayStatus/commissionRates
  • delegatedCapital should match currentPaydayStatus/delegatedCapital

Actual Result

  • equityCapital matches bakerEquityCapital
  • commissionRates matchespoolInfo/commissionRates
  • delegatedCapital matches delegatedCapital

Versions

  • Software Version: 6.*
  • OS: All
@td202 td202 added the [Type] Bug Something isn't working label May 27, 2024
@td202 td202 self-assigned this May 27, 2024
Copy link
Contributor Author

td202 commented May 27, 2024

This will be addressed as part of the API changes for cooldown (#1146).

@td202 td202 mentioned this issue Jun 26, 2024
5 tasks
@td202 td202 mentioned this issue Aug 1, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant