-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unknown Annotations #55
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-evans
force-pushed
the
unknown-annotation
branch
from
June 18, 2018 21:32
8d7d14f
to
5402f7d
Compare
bachbui
approved these changes
Jun 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Nice additions to the @atjson/document tests
blaine
approved these changes
Jun 25, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic - Understand :all-the-things:
tim-evans
changed the base branch from
annotation-abstract-class
to
annotation-classes
June 25, 2018 18:18
…emove this from our code rn
tim-evans
force-pushed
the
unknown-annotation
branch
from
June 25, 2018 18:37
7cc10b3
to
ca5c847
Compare
tim-evans
added a commit
that referenced
this pull request
Jun 25, 2018
This casts any annotations not identified in the schema list into an UnknownAnnotation. Unknown Annotations are AtJSON's form of Ruby's `method_missing`, with the added benefit that these annotations will be stored and updated in a document even after being updated.
tim-evans
added a commit
that referenced
this pull request
Aug 17, 2018
This casts any annotations not identified in the schema list into an UnknownAnnotation. Unknown Annotations are AtJSON's form of Ruby's `method_missing`, with the added benefit that these annotations will be stored and updated in a document even after being updated.
tim-evans
added a commit
that referenced
this pull request
Sep 26, 2018
This casts any annotations not identified in the schema list into an UnknownAnnotation. Unknown Annotations are AtJSON's form of Ruby's `method_missing`, with the added benefit that these annotations will be stored and updated in a document even after being updated.
tim-evans
added a commit
that referenced
this pull request
Oct 11, 2018
This casts any annotations not identified in the schema list into an UnknownAnnotation. Unknown Annotations are AtJSON's form of Ruby's `method_missing`, with the added benefit that these annotations will be stored and updated in a document even after being updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds formal support for unknown annotations.
Unknown Annotations have a particular way of being created; they stuff their
type
andattributes
into theattributes
. This means all data is retained for these annotations, while they appear as a homogenous blob. When rendered, these annotations will get categorized into a single bucket ofunknown
, so they can be rendered for debugging purposes in a document.For an example, if we import the following HTML document into AtJSON,
The document created would be a bunch of Unknown Annotations: