🎨 Fix rendering API to handle annotation classes #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the rendering API so annotation classes can be reused in the render hooks.
Previously, when an annotation was rendered, it would be called with the attributes, that stripped all type information:
Now, classes can be reused:
In addition! There is now metadata associated on annotations passed to renderers for tricky rendering scenarios like markdown, which will hopefully remove the need for fully-custom renderers! ✨ (For context, this is currently being done here and used for ambiguous nesting of bold and italic and adjacent lists of the same type)