Apply filtered Surrogate-Control TTL value #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
dennisroethig
commented
Oct 6, 2016
| @@ -61,5 +61,6 @@ public function get_seconds() { | |||
| */ | |||
| public function set_seconds( $seconds ) { | |||
| $this->_seconds = $seconds; | |||
| $this->set_value( $this->prepare_value( $seconds ) ); | |||
There was a problem hiding this comment.
I noticed the purgely_set_ttl helper function was also broken due to this missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
While trying to find a solution to serve different TTLs for different page types I noticed that applied changes to the
purgely_surrogate_controlfilter never make it through to the headers.Details
Seems like this is a known issue but was never addressed. As we will likely require this functionality in the near future we thought it would make sense to fix that upstream. I'm happy to update/add specs where required if there's an interest in getting this fix merged.
Related issue
#26