Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin): outdated master key warning check #262

Merged
merged 1 commit into from
Jul 24, 2022

Conversation

kon14
Copy link
Contributor

@kon14 kon14 commented Jul 24, 2022

This fixes Admin's unset MASTER_KEY env var security warning check not working for new env name.
I kept the older form (masterkey) around.

We can cleanup older env names in v0.15 with the next compak break.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature

Other information:

@kon14 kon14 requested a review from kkopanidis July 24, 2022 15:20
@kkopanidis kkopanidis merged commit 15af18e into main Jul 24, 2022
@kkopanidis kkopanidis deleted the fix-masterkey-warning branch July 24, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants