Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage,grpc-sdk): fix storage rpc functions #583

Merged
merged 2 commits into from
Apr 7, 2023
Merged

fix(storage,grpc-sdk): fix storage rpc functions #583

merged 2 commits into from
Apr 7, 2023

Conversation

ChrisPdgn
Copy link
Contributor

@ChrisPdgn ChrisPdgn commented Apr 7, 2023 •
edited
Loading

Fixes:

  • Storage rpc function params
  • Container param missing in createFileRequest & updateFileRequest in protofile
  • Add missing updated file to response of admin route createFileByUrl & both UpdateFileByUrl endpoints

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

@kkopanidis kkopanidis merged commit c799c5d into main Apr 7, 2023
@kkopanidis kkopanidis deleted the fix-storage branch April 7, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkopanidis kkopanidis kkopanidis approved these changes

@kon14 kon14 Awaiting requested review from kon14

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisPdgn @kkopanidis