Skip to content
This repository has been archived by the owner on Sep 25, 2023. It is now read-only.

Open Discussion on Plugin Integration #53

Open
anthonylavado opened this issue Jul 5, 2022 · 8 comments
Open

Open Discussion on Plugin Integration #53

anthonylavado opened this issue Jul 5, 2022 · 8 comments

Comments

@anthonylavado
Copy link
Contributor

anthonylavado commented Jul 5, 2022

👋 Hi! I'm Anthony from the Jellyfin Core Team. As the plugin is getting to be more popular, we'd like to talk a bit about how we can best support you, or even bring the plugin/web changes to be part of the project.

Would you be interested in joining our chat to discuss this further? We're primarily on Matrix, but you can join via Discord too. One note is that if you join via Discord, then we wouldn't be able to DM/etc.

Our contact links are all here: https://jellyfin.org/contact/

Edit: I see you're in some of the rooms already! Send me a ping whenever you're around.

@sourpatched
Copy link

@anthonylavado @ConfusedPolarBear
As I big fan of Jellyfin and now a fan of this project like many other people. Can we have an update on this Open Discussion?

60+ people are keen for more.

@anthonylavado
Copy link
Contributor Author

anthonylavado commented Jul 18, 2022

@sourpatched Sure. A few points.

Together:

  • We are also fans of this plugin
  • We'd like to work together on further support for plugins of this type (intro/outro/segment) skipping
  • Starting with Jellyfin 10.8, we build the Chromaprint library in with Jellyfin-FFmpeg 5.x, so that this plugin can work with what the server already uses (Small edit: This applies to Jellyfin on Linux and Windows. macOS does not have Chromaprint support yet.)

Longer-Term Jellyfin side:

  • Building a robust system for plugins of this type to hook into
  • Consolidating storage of segments to skip in a common format for the server to provide to clients (JSON? In the database? EDL? Chapter data?)
  • Providing standard buttons and controls surrounding segment skipping in the web UI and other client UIs, so that a plugin can invoke them

This is all very high level still. If we're talking about when changes would be visible, it would be 10.9 at the earliest. Once a release number (e.g. 10.8) goes out, any maintenance releases (e.g. 10.8.1) are bug fixes. No new features. The main project is working on better build systems and we're hoping to make faster releases with it.

Sorry if it's not the answer you were hoping to hear just yet, but we're working on it 🤠

@sourpatched
Copy link

@anthonylavado This is welcoming news! I am already excited for 10.9 and beyond! Thank you for the detailed response.

Is this going to be apart of the jellyfin family? of cause @ConfusedPolarBear get credited.

I came from Plex and ended up finding Jellyfin years ago, since then I have never looked back as Jellyfin is a one of a kind community.

@06kellyjac
Copy link

A way for plugins to modify the web interface would be super powerful 🚀

@MagicTrevor
Copy link

Definitely appreciate the support the team is giving and planning to give to plugins like this as well as future ones. Looking forward to the better integration!

@anthonylavado
Copy link
Contributor Author

@ConfusedPolarBear We're beginning discussions over what segment skipping would look like. You can see the discussion here:
jellyfin/jellyfin-meta#30


To all other interested parties/fans:

I would ask that you refrain from commenting unless you have a technical reason/comment. If you just want to show your support, feel free to leave reactions/upvotes. If updates are what you're after, there is a subscribe button at the bottom of the discussion. Posting extra comments always sends messages to more people that you think it does - this conversation here has four participants, but dozens of people that get an e-mail/ping.

However, thank you for your support. We love Jellyfin as much as you all do and we want to keep pushing it forward.

@Ge082
Copy link

Ge082 commented Nov 6, 2022

For outro skipping (if it is still in the planning phase), the simplest solution is to take advantage of the "up next / continue watching" feature, if audio fingerprint / image match an outro then trigger the "up next" poppup seconds before or just when the credits starts, else use the default "up next" timer.
Because it's already a good addition to Jellyfin, why not improve it in a smarter way if the Intro Skipper plugin gets natively integrated within Jellyfin

@JVT038
Copy link

JVT038 commented Feb 16, 2023

For outro skipping (if it is still in the planning phase), the simplest solution is to take advantage of the "up next / continue watching" feature, if audio fingerprint / image match an outro then trigger the "up next" poppup seconds before or just when the credits starts, else use the default "up next" timer.

Some movies and shows (like Marvel movies and the Star Wars show 'Andor') have a post-credit scene.
If you were to just continue to the next episode / movie, then this post-credit scene would be skipped.
I think it would be better to skip the credits instead and continue to the post-credit scene.
Or maybe it can detect whether a post-credit scene exists, and show 'up next' if there is no post-credit scene. But if there is a post-credit scene, it should show 'skip credits'.

Plex has recently introduced a skip credits feature, which does the same I mentioned above.
From Plex:

When playing content in a supported app, a “Skip Credits” button will appear when the credits start. This is overlaid on the video, allowing you to select it to skip the credits. If extra scenes during or after the credits were detected, then playback will skip to those

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants