Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

latest version of scssphp #86

Merged
merged 2 commits into from
Jan 22, 2018
Merged

latest version of scssphp #86

merged 2 commits into from
Jan 22, 2018

Conversation

hellerbenjamin
Copy link
Collaborator

Old version had depreciation error.

@brrn brrn requested a review from maindaniel December 27, 2017 18:01
maindaniel
maindaniel approved these changes Jan 3, 2018
View reviewed changes
Copy link

@maindaniel maindaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hellerbenjamin updated scssphp. All functionality works as intended after update.

@hellerbenjamin
Copy link
Collaborator Author

Thanks Daniel. Do you expect to update the WP repository version anytime soon?

@hellerbenjamin
Removed get_screen()
fbf2f84 
Deprecated function, no longer needed.
@brrn brrn merged commit 1ec0777 into ConnectThink:master Jan 22, 2018
@brrn
Copy link
Collaborator

brrn commented Jan 22, 2018

This has been merged and pushed to the plugin directory. Thanks for your help @hellerbenjamin!

@hellerbenjamin
Copy link
Collaborator Author

Thanks, it's a great plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maindaniel maindaniel maindaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hellerbenjamin @brrn @maindaniel