Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PropTypes to the React components definition #21

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

jbbn
Copy link
Contributor

@jbbn jbbn commented Oct 8, 2021

Closes #18

@jbbn
Copy link
Contributor Author

jbbn commented Oct 8, 2021

@Michael55555 I did everything that was mentioned on DeepSource 👍

Some notes and questions:

  • Will the PR checks make sure the build is ok? (the npm run build runs successfully here BUT I couldn't run the application - since I used GitPod for the development 😅, which doesn't have graphics for running an Electron app)
  • For some reason the package-lock.json changed a lot (when it should only add the new dependency (the facebook/prop-types) - do you know how to solve that? maybe your setup or node/npm version are somehow different than mine 🤔)

@m5x5
Copy link
Collaborator

m5x5 commented Oct 8, 2021

Hey @jbbn, thanks for the contribution, I really appreciate it! The checks don't make sure the code runs, unfortunately, we'll have to set it up later. I will check out the changes though.

For the package-lock.json I'm not sure why it changed so much to be honest, it might be because of the setup, maybe I should try to reinstall all dependencies and upload the new file then.

Copy link
Collaborator

@m5x5 m5x5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working perfectly fine, thanks for contributing to the project!

@m5x5 m5x5 merged commit 305c8a5 into ConnorFTW:main Oct 8, 2021
@jbbn
Copy link
Contributor Author

jbbn commented Oct 8, 2021

My pleasure @Michael55555 🙇‍♂️ 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(JS-0463) Consider adding propTypes to the React component definition
2 participants