feat: adds cs.AssertIsDifferent API in the ConstraintSystem
#131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbotrel
changed the title
cs.AssertIsDifferent API in the ConstraintSystem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #128 , that is a constraint to assert that 2 variables are different has been added.
@gbotrel internal changes --> the
ConstraintSystemstruct now containsdebugInfoComputation []logEntryanddebugInfoAssertion []logEntry, one for the computational constraints and the other for the assertions (formerly nameddebugInfo).A computational constraint fails only when a division by 0 occurs, so the
debugInfoComputationis populated each time an api call to a function using division is made. When solving the constraint system, a counter is incremented each time a division is done, so that when a division by zero happens the corresponding entry ins debugInfoComputation (of index counter) is displayed (using the callstack).