Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keccak-f permutation function #401

Merged
merged 4 commits into from
Jan 10, 2023
Merged

feat: keccak-f permutation function #401

merged 4 commits into from
Jan 10, 2023

Conversation

ivokub
Copy link
Collaborator

@ivokub ivokub commented Nov 19, 2022

Based on #399, but rewrote a bit to adapt for possible future byte-wise boolean ops.

@ivokub ivokub mentioned this pull request Nov 19, 2022
@ivokub ivokub self-assigned this Nov 20, 2022
@ivokub ivokub mentioned this pull request Nov 25, 2022
6 tasks
@ivokub ivokub force-pushed the feat/keccakf branch 2 times, most recently from 4191323 to 253d2ba Compare November 25, 2022 23:12
@ivokub
Copy link
Collaborator Author

ivokub commented Nov 25, 2022

Rebased on top of #403 to take advantage of variable compression, which allows to compile the circuit sufficiently fast for tests. As per #403 itself, then some tests are failing, but Keccak tests should succeed.

@ivokub ivokub marked this pull request as ready for review December 15, 2022 00:04
@ivokub
Copy link
Collaborator Author

ivokub commented Dec 15, 2022

Frontend changes and XOR implementation modification made compiling very efficient now.

@ivokub
Copy link
Collaborator Author

ivokub commented Dec 15, 2022

@ThomasPiellard, PR is now ready, could you have a look?

@ivokub ivokub merged commit 6bd6ac0 into develop Jan 10, 2023
@ivokub ivokub deleted the feat/keccakf branch January 10, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants