Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix race condition when compiling circuits in parallel #676

Merged
merged 1 commit into from
May 5, 2023
Merged

fix race condition when compiling circuits in parallel #676

merged 1 commit into from
May 5, 2023

Conversation

gbotrel
Copy link
Collaborator

@gbotrel gbotrel commented May 5, 2023

No description provided.

@gbotrel gbotrel requested review from Tabaie and ivokub May 5, 2023 14:28
ivokub
ivokub approved these changes May 5, 2023
View reviewed changes
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if atomic operations in test engine are necessary, but definitely doesn't hurt. Otherwise looks good.

@gbotrel
Copy link
Collaborator Author

gbotrel commented May 5, 2023

I'm not sure if atomic operations in test engine are necessary, but definitely doesn't hurt. Otherwise looks good.

go test -race said it was useful :p

@gbotrel gbotrel merged commit 5dae2c5 into develop May 5, 2023
@gbotrel gbotrel deleted the fix/raceblueprint branch May 5, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tabaie Tabaie Tabaie approved these changes

@ivokub ivokub ivokub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gbotrel @ivokub @Tabaie