Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arthimization code and include it as dependency #15

Merged
merged 9 commits into from
Jun 14, 2024

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented May 29, 2024

Replaces #6

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
powerslider and others added 8 commits May 29, 2024 15:34
# Conflicts:
#	acceptance-tests/src/test/java/org/hyperledger/besu/tests/acceptance/dsl/BlockUtils.java
#	arithmetization/src/test/java/net/consensys/linea/zktracer/testing/ToyAccount.java
#	arithmetization/src/test/java/net/consensys/linea/zktracer/testing/ToyExecutionEnvironment.java
#	gradle.properties
#	reference-tests/src/test/java/net/consensys/linea/CorsetBlockProcessor.java
#	reference-tests/src/test/java/net/consensys/linea/GeneralStateReferenceTestTools.java
@powerslider powerslider merged commit f30b9e4 into main Jun 14, 2024
6 checks passed
@powerslider powerslider deleted the arithmetization-removal branch June 14, 2024 10:54
@fab-10
Copy link
Contributor Author

fab-10 commented Jun 14, 2024

@powerslider now that this is merged I assume that new releases of this repo should NOT be done using the temp/issue-248/count-stack-only branch as we did until now, but from main and we can delete that branch since it is now it is obsoleted by the linea-arithemetization version 0.1.5-rc1 jar, right?

@fab-10
Copy link
Contributor Author

fab-10 commented Jun 19, 2024

after syncing with @powerslider, we still need to use that branch for releases until we totally switch off of geth, and that a linea-arithmetization artifact should be published that is built from the branch https://github.com/Consensys/linea-arithmetization/tree/temp/issue-248/count-stack-only.

After this artifact is ready we can use it as dependency in this project to build a new release.

FYI: @letypequividelespoubelles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants